Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed spec based on new validations added to ConversionHost model #485

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Fixed spec based on new validations added to ConversionHost model #485

merged 1 commit into from
Dec 13, 2018

Conversation

gmcculloug
Copy link
Member

New validation added in ManageIQ/manageiq#18277

Fixes failing tests.

@coveralls
Copy link

coveralls commented Dec 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 2461

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.185%
Totals Coverage Status
Change from base Build 2430: 0.0%
Covered Lines: 2935
Relevant Lines: 3020
💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Dec 12, 2018

Checked commit gmcculloug@1ad7eea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@tinaafitz tinaafitz merged commit 092bcc1 into ManageIQ:master Dec 13, 2018
@tinaafitz tinaafitz added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 18, 2018
@gmcculloug gmcculloug deleted the fix_conversion_host_spec_setup branch January 1, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tinaafitz tinaafitz

Labels
bug v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmcculloug @coveralls @miq-bot @tinaafitz