Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to delegate task and conversion host code to backend #441

Merged
merged 11 commits into from
Oct 19, 2018
Merged

Refactor to delegate task and conversion host code to backend #441

merged 11 commits into from
Oct 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2018 •
edited by ghost
Loading

The PR aims at refactoring the code after moving most of the code related to tasks and conversion hosts to the ManageIQ models. This reduces the amount of code and should simplify maintenance.

Depends on:

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1634029

@ghost
Copy link
Author

ghost commented Oct 9, 2018

@miq-bot add-label transformation, hammer/yes, wip

@miq-bot miq-bot changed the title Refactor to delegate task and conversion host code to backend [WIP] Refactor to delegate task and conversion host code to backend Oct 9, 2018
@ghost ghost mentioned this pull request Oct 15, 2018
Merged
@gmcculloug gmcculloug closed this Oct 15, 2018
@gmcculloug gmcculloug reopened this Oct 15, 2018
@ghost ghost force-pushed the v2v_move_code_to_backend_1 branch from 31d0e1c to b515b28 Compare October 18, 2018 14:43
@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2018

Some comments on commits fabiendupont/manageiq-content@6b6aee9~...b00873a

content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/methods/setdescription.rb

  • 💣 💥 🔥 🚒 - 16 - Detected cloudforms

@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2018

Checked commits fabiendupont/manageiq-content@6b6aee9~...b00873a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
25 files checked, 6 offenses detected

content/automate/ManageIQ/Transformation/Common.class/methods/killvirtv2v.rb

content/automate/ManageIQ/Transformation/Common.class/methods/setmigrated.rb

content/automate/ManageIQ/Transformation/Common.class/methods/vmchecktransformed.rb

content/automate/ManageIQ/Transformation/Common.class/methods/vmtransform.rb

content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/methods/collapsesnapshots.rb

content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/methods/setdescription.rb

@ghost
Copy link
Author

ghost commented Oct 18, 2018

@miq-bot remove-label wip

@miq-bot miq-bot changed the title [WIP] Refactor to delegate task and conversion host code to backend Refactor to delegate task and conversion host code to backend Oct 18, 2018
@miq-bot miq-bot removed the wip label Oct 18, 2018
@gmcculloug gmcculloug self-assigned this Oct 18, 2018
tinaafitz
tinaafitz approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdupont-redhat looks good.

mkanoor
mkanoor reviewed Oct 19, 2018
View reviewed changes
...utomate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/checkpoweredon.rb
@@ -7,20 +7,20 @@ module Common
class CheckPoweredOn
def initialize(handle = $evm)
@handle = handle
@task = ManageIQ::Automate::Transformation::Common::Utils.task(@handle)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdupont-redhat This block of code is being used in 2 places it might make sense to move them into an embedded method in a future PR

mkanoor
mkanoor approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@mkanoor mkanoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks code there is some common code that can be moved to embedded methods in a separate PR later on

@tinaafitz tinaafitz merged commit 8e7ed4d into ManageIQ:master Oct 19, 2018
@ghost ghost deleted the v2v_move_code_to_backend_1 branch October 19, 2018 18:42
This was referenced Oct 19, 2018
Closed
Closed
Merged
simaishi pushed a commit that referenced this pull request Oct 19, 2018
@tinaafitz @simaishi
Merge pull request #441 from fdupont-redhat/v2v_move_code_to_backend_1
2faee27 
Refactor to delegate task and conversion host code to backend

(cherry picked from commit 8e7ed4d)

https://bugzilla.redhat.com/show_bug.cgi?id=1634029
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 2faee2798f779cd04ce293819ccd8f15ab0b4e2e
Author: tina <[email protected]>
Date:   Fri Oct 19 13:47:29 2018 -0400

    Merge pull request #441 from fdupont-redhat/v2v_move_code_to_backend_1
    
    Refactor to delegate task and conversion host code to backend
    
    (cherry picked from commit 8e7ed4dd5d1faf5ce132b0f7a20af4c1265c0cc5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1634029

@tinaafitz tinaafitz added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 23, 2018
@ghost ghost mentioned this pull request Nov 7, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
hammer/backported refactoring v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miq-bot @simaishi @tinaafitz @mkanoor @gmcculloug @fabiendupont