Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate - Copy ConfigurationManagement to AutomationManagement. #33

Merged
merged 5 commits into from
Feb 7, 2017
Merged

Automate - Copy ConfigurationManagement to AutomationManagement. #33

merged 5 commits into from
Feb 7, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

Copied entire ConfigurationManagement to new AutomationManager namespace.

@tinaafitz tinaafitz mentioned this pull request Feb 3, 2017
Merged
mkanoor
mkanoor reviewed Feb 6, 2017
View reviewed changes
...Management/AnsibleTower/Operations/StateMachines/Job.class/__methods__/launch_ansible_job.rb Outdated
# wait for the job to finish.
#

class LaunchAnsibleJob
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billfitzgerald0120
Since this is a new method should we add the module around the class

@billfitzgerald0120 billfitzgerald0120 force-pushed the copy_configuration_to_automation branch 2 times, most recently from e282849 to faa68eb Compare February 6, 2017 23:55
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

Some comments on commits billfitzgerald0120/manageiq-content@faa68eb~...98a0714

spec/content/automate/ManageIQ/AutomationManagement/AnsibleTower/Operations/StateMachines/Job.class/methods/wait_for_completion_spec.rb

  • ⚠️ - 17 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 18 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 24 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 30 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 31 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 37 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 38 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/content/automate/ManageIQ/AutomationManagement/AnsibleTower/Operations/StateMachines/Job.class/methods/wait_for_ip_spec.rb

  • ⚠️ - 15 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 16 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 25 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 26 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/content/automate/ManageIQ/AutomationManagement/AnsibleTower/Service/Provisioning/StateMachines/Provision.class/methods/check_provisioned_spec.rb

  • ⚠️ - 18 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 21 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 30 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 38 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/content/automate/ManageIQ/AutomationManagement/AnsibleTower/Service/Provisioning/StateMachines/Provision.class/methods/preprovision_spec.rb

  • ⚠️ - 13 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 14 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

Checked commits billfitzgerald0120/manageiq-content@faa68eb~...98a0714 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
17 files checked, 0 offenses detected
Everything looks good. 🍰

@mkanoor mkanoor merged commit dc570af into ManageIQ:master Feb 7, 2017
@mkanoor mkanoor mentioned this pull request Feb 7, 2017
Closed
@mkanoor mkanoor added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billfitzgerald0120 @miq-bot @mkanoor