Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring cloud vm retirement delete_from_vmdb method #319

Merged
merged 2 commits into from
Jun 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,11 +1,36 @@
#
# Description: This method removes the VM from the VMDB database
#
module ManageIQ
module Automate
module Cloud
module VM
module Retirement
module StateMachines
module Methods
class DeleteFromVmdb
def initialize(handle = $evm)
@handle = handle
end

vm = $evm.root['vm']
def main
vm = @handle.root['vm']

if vm && $evm.get_state_var('vm_removed_from_provider')
$evm.log('info', "Removing VM <#{vm.name}> from VMDB")
vm.remove_from_vmdb
$evm.root['vm'] = nil
if vm && @handle.get_state_var('vm_removed_from_provider')
@handle.log('info', "Removing VM <#{vm.name}> from VMDB")
vm.remove_from_vmdb
@handle.root['vm'] = nil
end
end
end
end
end
end
end
end
end
end

if $PROGRAM_NAME == __FILE__
ManageIQ::Automate::Cloud::VM::Retirement::StateMachines::Methods::DeleteFromVmdb.new.main
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
require_domain_file

describe ManageIQ::Automate::Cloud::VM::Retirement::StateMachines::Methods::DeleteFromVmdb do
let(:svc_vm) { MiqAeMethodService::MiqAeServiceVm.find(vm.id) }
let(:ems) { FactoryGirl.create(:ems_vmware) }
let(:vm) { FactoryGirl.create(:vm_vmware, :ems_id => ems.id) }
let(:root_object) { Spec::Support::MiqAeMockObject.new(root_hash) }
let(:root_hash) { { 'vm' => svc_vm } }

let(:ae_service) do
Spec::Support::MiqAeMockService.new(root_object).tap do |service|
current_object = Spec::Support::MiqAeMockObject.new
current_object.parent = root_object
service.object = current_object
end
end

it 'removes vm from vmdb' do
ae_service.set_state_var('vm_removed_from_provider', true)
expect(svc_vm).to(receive(:remove_from_vmdb))
described_class.new(ae_service).main
end

context 'does not remove vm from vmdb' do
it '#nil vm' do
root_hash['vm'] = nil
expect(ae_service).not_to(receive(:log))
described_class.new(ae_service).main
end

it '#without vm_removed_from_provider state_var' do
expect(svc_vm).not_to(receive(:remove_from_provider))
expect(ae_service).not_to(receive(:log))
described_class.new(ae_service).main
end
end
end