Ability to retire a service from service dialog #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per[1] we can retire a service but including 'service_retire_on' in service dialog still needs customization in Automate. This is discussed in [2]. I think ManageIQ Domain should handle 'service_retire_on' dialog option by default. This will save creating a custom domain just to fetch 'service_retire_on' value from service catalog. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1300428 [2] http://talk.manageiq.org/t/services-retirement-date/786/2 Closes-Bug: BZ#1506712
psachin
force-pushed
the
retire_service
branch
from
9544164 to
5230b31
Compare
|
Checked commit psachin@5230b31 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Closing in favor of PR ManageIQ/manageiq#16799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per[1] we can retire a service but including 'service_retire_on' in
service dialog still needs customization in Automate. This is
discussed in [2].
I think ManageIQ Domain should handle 'service_retire_on' dialog
option by default. This will save creating a custom domain just to
fetch 'service_retire_on' value from service catalog.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1300428
[2] http://talk.manageiq.org/t/services-retirement-date/786/2
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1506712