v2v: Add automate methods for post-import network configuration #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @tinaafitz |
|
@miq-bot add_label fine/yes |
matobet
force-pushed
the
v2v-network-automate
branch
from
e1d70d6 to
e55af9d
Compare
|
Depends on ManageIQ/manageiq-automation_engine#35 |
matobet
force-pushed
the
v2v-network-automate
branch
from
e55af9d to
999f6c6
Compare
tinaafitz
suggested changes
Jun 2, 2017
| @@ -19,6 +19,7 @@ def main | |||
| status = vm.custom_get(:import_status) | |||
| case status | |||
| when 'success' | |||
| @handle.set_state_var('imported_vm_id', vm.id) | |||
There was a problem hiding this comment.
@matobet, can we update the spec test?
| @@ -0,0 +1,43 @@ | |||
| # | |||
There was a problem hiding this comment.
@matobet Can we add a test for this method?
matobet
force-pushed
the
v2v-network-automate
branch
from
999f6c6 to
77e5a3b
Compare
|
Checked commit matobet@77e5a3b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
tinaafitz
approved these changes
Jun 7, 2017
|
@gmcculloug Please review. |
simaishi
pushed a commit
that referenced
this pull request
Jun 14, 2017
v2v: Add automate methods for post-import network configuration (cherry picked from commit 4167dfa) https://bugzilla.redhat.com/show_bug.cgi?id=1459996
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1404920
Depends on ManageIQ/manageiq-automation_engine#35