Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeted refresh enhacements for VM import\rename\migration events #119

Merged
merged 1 commit into from
May 30, 2017

Conversation

pkliczewski
Copy link
Contributor

We need to make sure that we target vm when refreshing after import,
rename or migration events.

Bug:
https://bugzilla.redhat.com/1404357

We need to make sure that we target vm when refreshing after import,
rename or migration events.

Bug:
https://bugzilla.redhat.com/1404357
@pkliczewski
Copy link
Contributor Author

@miq-bot assign @gmcculloug

@pkliczewski
Copy link
Contributor Author

@borod108 @masayag please review

@miq-bot
Copy link
Member

miq-bot commented May 26, 2017

Checked commit pkliczewski@613ad50 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@gmcculloug
Copy link
Member

cc @lfu

@borod108
Copy link

@pkliczewski When migrating the Vm we should refresh the cluster as well, don't we?
So this will work when the changes that add refreshing the cluster as part of the vm targeted refresh are merged?

@pkliczewski
Copy link
Contributor Author

@borod108 We refresh cluster [1] when we target a vm. The change you mentioned use vm as a target rather than ems.

[1] https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/app/models/manageiq/providers/redhat/infra_manager/refresh/strategies/api3.rb#L24

@pkliczewski
Copy link
Contributor Author

Migration verified on small env using one vm.

@gmcculloug gmcculloug merged commit 6e4e6f2 into ManageIQ:master May 30, 2017
@gmcculloug gmcculloug added this to the Sprint 62 Ending Jun 5, 2017 milestone May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants