Add missing service model change for calculating active quota counts for Service requests. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, fine/yes, provisioning |
|
@tinaafitz Cannot apply the following label because they are not recognized: provisioning |
|
Checked commit tinaafitz@05ef42b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@mkanoor Please review. |
mkanoor
approved these changes
Sep 14, 2017
|
@miq-bot add_label blocker |
|
Fine backport (to manageiq repo) details: |
|
@miq-bot add_label euwe/yes |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added miq_provision_quota mixin include to Service Template Provision Request Service model.
Recently added the ability to calculate active quota counts for Service and VM requests. Missing include results in Service requests getting undefined error while running check_quota() method.
https://bugzilla.redhat.com/show_bug.cgi?id=1491409
Original ticket/PR to add active quota calculations modify prov methods.
https://bugzilla.redhat.com/show_bug.cgi?id=1456819
ManageIQ/manageiq#15466