Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't unconditionally update verify_ssl #52

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Don't unconditionally update verify_ssl #52

merged 1 commit into from
Jul 13, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Jul 13, 2017 •
edited by gmcculloug
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1470738

The verify_ssl attribute in the git repository was being updated to 1 when being called from the REST API.

@mkanoor mkanoor added the bug label Jul 13, 2017
@mkanoor mkanoor requested a review from gmcculloug July 13, 2017 15:48
@miq-bot
Copy link
Member

miq-bot commented Jul 13, 2017

Checked commit mkanoor@0f7a2db with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@gmcculloug gmcculloug mentioned this pull request Jul 13, 2017
Closed
@gmcculloug gmcculloug merged commit 928f892 into ManageIQ:master Jul 13, 2017
@gmcculloug gmcculloug added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 13, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 8fc67b4772042226aa3ccd3e9fb77ae164117ef1
Author: Greg McCullough <[email protected]>
Date:   Thu Jul 13 13:07:33 2017 -0400

    Merge pull request #52 from mkanoor/miq_ae_git_import
    
    Don't unconditionally update verify_ssl
    (cherry picked from commit 928f892b7e06f57082bb81557b292f0240d73101)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1471204

@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit b28635de0353b51fdb3e793c603fa17eae71f854
Author: Greg McCullough <[email protected]>
Date:   Thu Jul 13 13:07:33 2017 -0400

    Merge pull request #52 from mkanoor/miq_ae_git_import
    
    Don't unconditionally update verify_ssl
    (cherry picked from commit 928f892b7e06f57082bb81557b292f0240d73101)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug Awaiting requested review from gmcculloug

Assignees

@gmcculloug gmcculloug

Labels
bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkanoor @miq-bot @simaishi @gmcculloug