Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the expose of manager to Embedded Ansible Job in service model. #47

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented Jul 5, 2017

The :manager association to Embedded Ansible Job does not exist in the model side.

https://bugzilla.redhat.com/show_bug.cgi?id=1465826

@miq-bot assign @gmcculloug
@miq-bot add_label bug, fine/yes

The :manager association to Embedded Ansible Job does not exist in the model side.

https://bugzilla.redhat.com/show_bug.cgi?id=1465826
@miq-bot
Copy link
Member

miq-bot commented Jul 5, 2017

Checked commit lfu@7518938 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug
Copy link
Member

👍

@gmcculloug gmcculloug merged commit bce0b06 into ManageIQ:master Jul 5, 2017
@gmcculloug gmcculloug added this to the Sprint 64 Ending Jul 3, 2017 milestone Jul 5, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit 03d6f15e269fa982f7f387e48db068dc6d3d59fa
Author: Greg McCullough <[email protected]>
Date:   Wed Jul 5 17:29:03 2017 -0400

    Merge pull request #47 from lfu/ansible_job_manager_1465826
    
    Remove the expose of manager to Embedded Ansible Job in service model.
    (cherry picked from commit bce0b069d6ce4740e5f8349f685224518c468061)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478515

@gmcculloug
Copy link
Member

@simaishi Looks like the back-port to the fine branch is breaking tests. Upstream we can dynamically create these automate service models if the class does not contain any logic. In this case we were removing the only line:
expose :manager, :association => true

But for back-porting we need to keep the empty models since they are not dynamically created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants