Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back missing requires for rubyzip #400

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Add back missing requires for rubyzip #400

merged 1 commit into from
Dec 12, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Dec 12, 2019 •
edited
Loading

Yes, fine, I broke this in #397

We need these requires, see https://travis-ci.org/ManageIQ/manageiq-automation_engine/jobs/624227071#L1856.

the related pr is ManageIQ/manageiq#19636

@d-m-u d-m-u mentioned this pull request Dec 12, 2019
Merged
@miq-bot
Copy link
Member

miq-bot commented Dec 12, 2019

Checked commit d-m-u@09524e4 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@coveralls
Copy link

coveralls commented Dec 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3437

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 85.281%
Totals Coverage Status
Change from base Build 3434: 0.6%
Covered Lines: 5029
Relevant Lines: 5897
💛 - Coveralls

@gmcculloug gmcculloug self-assigned this Dec 12, 2019
@gmcculloug gmcculloug added the bug label Dec 12, 2019
@gmcculloug gmcculloug merged commit 309f9be into ManageIQ:master Dec 12, 2019
@gmcculloug gmcculloug added this to the Sprint 127 Ending Jan 6, 2020 milestone Dec 12, 2019
@d-m-u d-m-u deleted the fixing_zip_requires_that_i_just_broke branch December 12, 2019 17:23
simaishi pushed a commit that referenced this pull request Dec 13, 2019
@gmcculloug @simaishi
Merge pull request #400 from d-m-u/fixing_zip_requires_that_i_just_broke
4c44314 
Add back missing requires for rubyzip

(cherry picked from commit 309f9be)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783403
@simaishi simaishi mentioned this pull request Dec 13, 2019
Merged
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 4c443145c88fc2890dbaf4d82638652b9e228d94
Author: Greg McCullough <[email protected]>
Date:   Thu Dec 12 12:21:25 2019 -0500

    Merge pull request #400 from d-m-u/fixing_zip_requires_that_i_just_broke

    Add back missing requires for rubyzip

    (cherry picked from commit 309f9be75440871bbd734bce79780ce848dcd312)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783403

simaishi pushed a commit that referenced this pull request Dec 16, 2019
@gmcculloug @simaishi
Merge pull request #400 from d-m-u/fixing_zip_requires_that_i_just_broke
45ab9bd 
Add back missing requires for rubyzip

(cherry picked from commit 309f9be)

https://bugzilla.redhat.com/show_bug.cgi?id=1783401
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 45ab9bd705365bd421d9b98d2f81b6f4e1a14d8b
Author: Greg McCullough <[email protected]>
Date:   Thu Dec 12 12:21:25 2019 -0500

    Merge pull request #400 from d-m-u/fixing_zip_requires_that_i_just_broke

    Add back missing requires for rubyzip

    (cherry picked from commit 309f9be75440871bbd734bce79780ce848dcd312)

    https://bugzilla.redhat.com/show_bug.cgi?id=1783401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
bug hammer/backported ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @coveralls @simaishi @gmcculloug