Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask the password value in logs. #371

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Mask the password value in logs. #371

merged 1 commit into from
Sep 18, 2019

Conversation

lfu
Copy link
Member

@lfu lfu commented Sep 16, 2019 •
edited
Loading

Related to ManageIQ/manageiq#19299.

https://bugzilla.redhat.com/show_bug.cgi?id=1752033

@miq-bot add_label bug, hammer/yes, ivanchuk/yes, changelog/yes

@lfu lfu mentioned this pull request Sep 16, 2019
Merged
@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2019

Checked commit lfu@4fa2b61 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3062

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.275%
Totals Coverage Status
Change from base Build 3059: 0.0%
Covered Lines: 4992
Relevant Lines: 5854
💛 - Coveralls

@gmcculloug gmcculloug requested a review from mkanoor September 17, 2019 11:59
gmcculloug
gmcculloug approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the logging we are doing already on lines 81 and 95.
LGTM 👍

@gmcculloug
Copy link
Member

@tinaafitz @mkanoor Please review

@gmcculloug gmcculloug assigned gmcculloug and unassigned tinaafitz Sep 18, 2019
@gmcculloug gmcculloug merged commit 4be2d0a into ManageIQ:master Sep 18, 2019
@gmcculloug gmcculloug added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 18, 2019
simaishi pushed a commit that referenced this pull request Oct 4, 2019
@gmcculloug @simaishi
Merge pull request #371 from lfu/clean_up_message_1752033
58be3f1 
Mask the password value in logs.

(cherry picked from commit 4be2d0a)

https://bugzilla.redhat.com/show_bug.cgi?id=1758665
@simaishi
Copy link
Contributor

simaishi commented Oct 4, 2019

Hammer backport details:

$ git log -1
commit 58be3f101dc4bad432f4069821577ae0ef5ea336
Author: Greg McCullough <[email protected]>
Date:   Wed Sep 18 16:12:35 2019 -0400

    Merge pull request #371 from lfu/clean_up_message_1752033
    
    Mask the password value in logs.
    
    (cherry picked from commit 4be2d0a9edf5d5bf9cb7c91a72aa0f36f0c4b2ef)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1758665

simaishi pushed a commit that referenced this pull request Nov 1, 2019
@gmcculloug @simaishi
Merge pull request #371 from lfu/clean_up_message_1752033
2192b30 
Mask the password value in logs.

(cherry picked from commit 4be2d0a)

https://bugzilla.redhat.com/show_bug.cgi?id=1767789
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit 2192b305ceed4985a1350b0a9301f127395a8179
Author: Greg McCullough <[email protected]>
Date:   Wed Sep 18 16:12:35 2019 -0400

    Merge pull request #371 from lfu/clean_up_message_1752033
    
    Mask the password value in logs.
    
    (cherry picked from commit 4be2d0a9edf5d5bf9cb7c91a72aa0f36f0c4b2ef)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1767789

@lfu lfu deleted the clean_up_message_1752033 branch November 4, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug changelog/yes hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lfu @miq-bot @coveralls @gmcculloug @simaishi @mkanoor @Fryguy @tinaafitz