Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external_url= capability to Tenant. #350

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Aug 16, 2019

Add external_url= capability to Tenant.

Relevant BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1550002

This PR extends the work done in #328 in support of changes from ManageIQ/manageiq#18849

Tested automate code for "Tenant":

$evm.log(:info, $evm.root['vmdb_object_type'])
$evm.log(:info, "tenant_id: #{$evm.root['tenant_id'].inspect}")

# t = $evm.root['tenant'] # this will give the LOGGGED IN tenant, not the target object tenant
t = $evm.vmdb($evm.root['vmdb_object_type']).find_by(:id => $evm.root['tenant_id'])
$evm.log(:info, "tenant: #{t.inspect}")
t.external_url = "https://www.redhat.com"

@martinpovolny
Copy link
Member Author

@miq-bot add_label bug, ivanchuk/yes

@miq-bot
Copy link
Member

miq-bot commented Aug 16, 2019

Checked commit martinpovolny@c3663e3 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@coveralls
Copy link

coveralls commented Aug 16, 2019

Pull Request Test Coverage Report for Build 2902

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 85.153%

Totals Coverage Status
Change from base Build 2893: 0.03%
Covered Lines: 4961
Relevant Lines: 5826

💛 - Coveralls

@gmcculloug gmcculloug self-assigned this Aug 16, 2019
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the models updated in ManageIQ/manageiq#18849 are all accounted for now. 👍

@gmcculloug gmcculloug merged commit 6f03629 into ManageIQ:master Aug 16, 2019
@gmcculloug gmcculloug added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants