Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource to conversion_host to pass validation #275

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Add resource to conversion_host to pass validation #275

merged 1 commit into from
Dec 12, 2018

Conversation

gmcculloug
Copy link
Member

@gmcculloug gmcculloug commented Dec 12, 2018 •
edited
Loading

Fixed spec based on new validations added to ConversionHost model in ManageIQ/manageiq#18277

Should fix failing tests.

@gmcculloug gmcculloug added the bug label Dec 12, 2018
@miq-bot
Copy link
Member

miq-bot commented Dec 12, 2018

Checked commit gmcculloug@6327d46 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1827

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.571%
Totals Coverage Status
Change from base Build 1776: -0.02%
Covered Lines: 5225
Relevant Lines: 6485
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1827

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.571%
Totals Coverage Status
Change from base Build 1776: -0.02%
Covered Lines: 5225
Relevant Lines: 6485
💛 - Coveralls

@mkanoor mkanoor merged commit 29cb3f9 into ManageIQ:master Dec 12, 2018
@mkanoor mkanoor added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 12, 2018
simaishi pushed a commit that referenced this pull request Apr 22, 2019
@mkanoor @simaishi
Merge pull request #275 from gmcculloug/fix_transformation_plan_task_…
f525b10 
…spec

Add resource to conversion_host to pass validation

(cherry picked from commit 29cb3f9)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f525b1030aea621d5269817d8942d5062c28cc97
Author: Madhu Kanoor <[email protected]>
Date:   Wed Dec 12 13:59:51 2018 -0500

    Merge pull request #275 from gmcculloug/fix_transformation_plan_task_spec
    
    Add resource to conversion_host to pass validation
    
    (cherry picked from commit 29cb3f9f65561e4325f7eefa3b2bcc65449ccda9)

@gmcculloug gmcculloug deleted the fix_transformation_plan_task_spec branch January 1, 2020 21:16
@Fryguy Fryguy added v2v and removed transformation labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

Assignees

@mkanoor mkanoor

Labels
bug hammer/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gmcculloug @miq-bot @coveralls @simaishi @mkanoor @Fryguy