Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orch stack retirement task to category #238

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Add orch stack retirement task to category #238

merged 1 commit into from
Oct 1, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 1, 2018 •
edited
Loading

The orchestration stack retirement category wasn't being added.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632239 along with all the other things

Related PRs:

ManageIQ/manageiq-providers-vmware#324
ManageIQ/manageiq-content#437

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

@miq-bot add_reviewer @tinaafitz
@miq-bot add_reviewer @mkanoor

@miq-bot miq-bot requested review from tinaafitz and mkanoor October 1, 2018 17:17
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commit d-m-u@a7fc03b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 5 offenses detected

lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_builtin_method.rb

tinaafitz
tinaafitz approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks good. Let's update the spec tests in the content repo once this PR is merged.
@mkanoor Please review.

@mkanoor mkanoor merged commit 105b986 into ManageIQ:master Oct 1, 2018
@d-m-u d-m-u mentioned this pull request Oct 1, 2018
Merged
@mkanoor mkanoor added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 1, 2018
@mkanoor mkanoor added the bug label Oct 1, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

@miq-bot add_label bug

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

@miq-bot add_label hammer/yes
@miq-bot add_label gaprindashvili/yes

@d-m-u d-m-u deleted the fixing_orch_stack_retirement branch October 1, 2018 20:19
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@mkanoor @simaishi
Merge pull request #238 from d-m-u/fixing_orch_stack_retirement
27b8d0e 
Add orch stack retirement task to category

(cherry picked from commit 105b986)

https://bugzilla.redhat.com/show_bug.cgi?id=1632239
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit 27b8d0eab04059c96a59549d867073e63bc32528
Author: Madhu Kanoor <[email protected]>
Date:   Mon Oct 1 14:21:50 2018 -0400

    Merge pull request #238 from d-m-u/fixing_orch_stack_retirement
    
    Add orch stack retirement task to category
    
    (cherry picked from commit 105b986b07980ec6a69cd4b9332dc4a044bc9fe4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1632239

@d-m-u d-m-u restored the fixing_orch_stack_retirement branch October 2, 2018 20:16
@d-m-u d-m-u mentioned this pull request Oct 2, 2018
Merged
@tinaafitz tinaafitz mentioned this pull request Oct 4, 2018
Merged
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@mkanoor @simaishi
Merge pull request #238 from d-m-u/fixing_orch_stack_retirement
c47ec5f 
Add orch stack retirement task to category

(cherry picked from commit 105b986)

https://bugzilla.redhat.com/show_bug.cgi?id=1636494
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c47ec5f2c84967a828d4f9e6fc664cb43f7e2864
Author: Madhu Kanoor <[email protected]>
Date:   Mon Oct 1 14:21:50 2018 -0400

    Merge pull request #238 from d-m-u/fixing_orch_stack_retirement
    
    Add orch stack retirement task to category
    
    (cherry picked from commit 105b986b07980ec6a69cd4b9332dc4a044bc9fe4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1636494

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 11, 2018

@miq-bot add_label gaprindashvili/no

simaishi added a commit that referenced this pull request Oct 11, 2018
@simaishi
Revert "Merge pull request #238 from d-m-u/fixing_orch_stack_retirement"
1393729 
This reverts commit c47ec5f.

https://bugzilla.redhat.com/show_bug.cgi?id=1636494
@simaishi
Copy link
Contributor

Reverted the G backport.

commit 13937294796476f97b8bffa62ca6676d8b42cb69
Author: Satoe Imaishi <[email protected]>
Date:   Thu Oct 11 13:15:48 2018 -0400

    Revert "Merge pull request #238 from d-m-u/fixing_orch_stack_retirement"
    
    This reverts commit c47ec5f2c84967a828d4f9e6fc664cb43f7e2864.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1636494

@d-m-u d-m-u deleted the fixing_orch_stack_retirement branch February 11, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@mkanoor mkanoor

Labels
blocker bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-m-u @miq-bot @simaishi @tinaafitz @mkanoor @gmcculloug