Validate the encryption key when configuring the database #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
approved these changes
Mar 20, 2018
|
@carbonin Think you can kick this and it will turn 🍏 |
|
Checked commits carbonin/manageiq-appliance_console@89a8a0d~...61922c4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
added a commit
to carbonin/manageiq-appliance_console
that referenced
this pull request
Aug 16, 2018
Before this, #validate_encryption_key! would return nil when successful because of the way the conditional was written, now if the rake task succeeds, we will return true. Introduced in ManageIQ#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ManageIQ/manageiq#17149
https://bugzilla.redhat.com/show_bug.cgi?id=1544854