Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure database ssl on creation #22

Merged
merged 4 commits into from
Dec 14, 2017
Merged

Configure database ssl on creation #22

merged 4 commits into from
Dec 14, 2017

Conversation

carbonin
Copy link
Member

This PR utilizes changes made in ManageIQ/manageiq-appliance#162 to generate ssl certs for encrypting database traffic.

It also removes conditional logic around setting the ssl option in postgresql.conf

@carbonin
Remove ssl attribute from InternalDatabaseConfiguration
44b6e58 
We are always going to use ssl from now on so it doesn't need to be
and attribute.
@carbonin
Copy pg_hba.conf rather than pg_hba.conf.erb
0b7340e 
The erb was only in the file to determine if we were using ssl or not.
It has now been removed.
@carbonin
Simplify InternalDatabaseConfiguration#copy_template
f28c27a 
Because we don't have any more erb files, this method can now
just copy the file directly
@carbonin
Generate ssl certs for PG if they are not present at install time
91b613f 
This will ensure that the server will use ssl for all connections
from the first time it starts up.
@carbonin carbonin requested a review from jrafanie December 11, 2017 20:01
@carbonin carbonin mentioned this pull request Dec 11, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2017

Checked commits carbonin/manageiq-appliance_console@44b6e58~...91b613f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 5 offenses detected

lib/manageiq/appliance_console/internal_database_configuration.rb

@carbonin
Copy link
Member Author

Related to https://bugzilla.redhat.com/show_bug.cgi?id=1482697 and https://bugzilla.redhat.com/show_bug.cgi?id=1519079

bdunne
bdunne approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

jrafanie
jrafanie approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bdunne bdunne merged commit 4a02064 into ManageIQ:master Dec 14, 2017
@bdunne bdunne assigned bdunne and unassigned gtanzillo Dec 14, 2017
@bdunne bdunne added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 14, 2017
carbonin added a commit to carbonin/manageiq-gems-pending that referenced this pull request Apr 30, 2018
@carbonin
Remove references to RAILS_ROOT
ee90116 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ/manageiq-appliance_console#22

Fixes ManageIQ#4
@carbonin carbonin mentioned this pull request Apr 30, 2018
Merged
@carbonin carbonin mentioned this pull request May 9, 2019
Merged
@carbonin carbonin deleted the ssl_by_default branch May 14, 2019 21:03
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 5, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
2a8ed1b 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 5, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
eb411e1 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 5, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
c643fda 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 9, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
db9b7a2 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 9, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
0e356db 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 9, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
0600057 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 11, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
c18945f 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
NickLaMuro pushed a commit to NickLaMuro/manageiq-appliance_console that referenced this pull request Mar 16, 2021
@carbonin @NickLaMuro
Remove references to RAILS_ROOT
1d16b19 
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ#22

Fixes ManageIQ#4


(transferred from ManageIQ/manageiq-gems-pending@ee90116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@jrafanie jrafanie jrafanie approved these changes

Assignees

@bdunne bdunne

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carbonin @miq-bot @jrafanie @bdunne @gtanzillo