Add support to automate external auth config for ldap #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
|
@jvlcek Cannot apply the following label because they are not recognized: authentication |
|
Checked commits jvlcek/manageiq-appliance@e237286~...c34dd6a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gtanzillo or @abellotti All changes discussed have been made. Please merge. |
abellotti
approved these changes
Oct 30, 2019
|
LGTM!!. Thanks @jvlcek for this new capability. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request goes with and relies on PR ManageIQ/manageiq#19228
This PR introduced a new executable miq_config_sssd_ldap and provides needed updates to
the existing commands: miqldap_to_sssd and normalize_userid_to_upn