Add NE to the ansible api rewrite rule #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we are proxying requests we don't want to re-encode already URI encoded values. Before this change, queries to the API like this: `api.activity_stream.all(timestamp__gt: '2000-01-01 12:12')` ended up with URLs like this: `/ansibleapi/v1/activity_stream?timestamp__gt=2000-01-01+12%3A12` which were then redirected to a URL which re-encodes the `%` character: `/ansibleapi/v1/activity_stream/?timestamp__gt=2000-01-01+12%253A12` This resulted in an invalid date format when un-encoded: `2000-01-01 12%3A12` ref: ManageIQ/manageiq#14279 ManageIQ/manageiq#14296
durandom
approved these changes
Mar 22, 2017
|
this is a reproducer in the rails console |
|
Checked commit carbonin@8a95682 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are proxying requests we don't want to re-encode already
URI encoded values.
Before this change, queries to the API like this:
api.activity_stream.all(timestamp__gt: '2000-01-01 12:12')ended up with URLs like this:
/ansibleapi/v1/activity_stream?timestamp__gt=2000-01-01+12%3A12which were then redirected to a URL which re-encodes the
%character:/ansibleapi/v1/activity_stream/?timestamp__gt=2000-01-01+12%253A12This resulted in an invalid date format when un-encoded:
2000-01-01 12%3A12ref:
ManageIQ/manageiq#14279
ManageIQ/manageiq#14296
/cc @durandom