create the resource action after save for custom buttons #821
Conversation
Rails 5.2 raises this error if you try to persist the child before creating the
parent: `Failed to create new custom button - You cannot call create unless the
parent is saved`
Followup to ManageIQ#814
Needed for Rails 5.2: ManageIQ/manageiq#20032
thanks keenan and lj
d-m-u
force-pushed
the
fixing_silly_create_before_parent
branch
from
cb5a8d3 to
5c730a4
Compare
|
Checked commit d-m-u@5c730a4 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
| custom_button.save! | ||
| custom_button.create_resource_action!(data["resource_action"].deep_symbolize_keys) if data.key?("resource_action") |
There was a problem hiding this comment.
just curious, can the create_resource_action! method somehow fail, and we end up with a created Object, but never used/returned ? do we need a transaction for the above two so the request is atomic ? @jrafanie thoughts ?
There was a problem hiding this comment.
I don't really think so. resource action create 1) has no validations and 2) are artifacts that link dialogs, resources, and automate, there's not much of a vector for failure
There was a problem hiding this comment.
yeah, probably similar to this one: ManageIQ/manageiq#20013
@d-m-u can you review if this is required and do a followup PR? This is great to fix the issue on rails 5.2
There was a problem hiding this comment.
We cross our streams at the same time and didn't use a mutex
create the resource action after save for custom buttons (cherry picked from commit da3529c)
|
Jansa backport details: |
otherwise this fails with
Failed to create new custom button - You cannot call create unless the parent is savedon rails 5.2 🤮Keenan caught it in https://travis-ci.com/github/ManageIQ/manageiq-cross_repo-tests/jobs/325865143#L2435
@miq-bot add_label jansa/yes, ivanchuk/yes
@miq-bot add_reviewer @jrafanie
@miq-bot add_label bug
Followup to #814
Needed for Rails 5.2: ManageIQ/manageiq#20032