/api/product_info - fix missing support_website, support_website_text #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
|
The i18n.t version was removed in ManageIQ/manageiq#19881, in favor of using Settings in ManageIQ/manageiq-ui-classic#6718. But the API is still using it, updating to do the same thing. (The SUI is using this for a menu item.)
|
Checked commit https://github.com/himdel/manageiq-api/commit/cb7dea7cf6f354fade8a3fea03c7ea18ce8ac95c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
@himdel Thank you for the fix, verified this works as well. |
mzazrivec
approved these changes
Mar 25, 2020
simaishi
pushed a commit
that referenced
this pull request
Mar 27, 2020
/api/product_info - fix missing support_website, support_website_text (cherry picked from commit f1e44be)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i18n.t version was removed in ManageIQ/manageiq#19881,
in favor of using Settings in ManageIQ/manageiq-ui-classic#6718.
But the API is still using it, updating to do the same thing.
(The SUI is using this for a menu item.)
Cc @mzazrivec @simaishi
@miq-bot add_label bug, jansa/yes?