(CI Failure Fix ) Put make_retire_request on queue in VmsController

[lpichler]

this is also fixing CI failure https://travis-ci.org/ManageIQ/manageiq-api/jobs/576957657

api request:

curl -X POST http://localhost:3090/api/vms/1 -d '{ "action" : "request_retire"}' ..

please review @lfu

Links

It was on core rep here: ManageIQ/manageiq#19064

@miq-bot assign @abellotti

Record in MiqQueue looks like after API request:

#<MiqQueue:0x00007f95628251a0> {
                :id => 133284175,
         :target_id => nil,
          :priority => 100,
       :method_name => "make_retire_request",
             :state => "ready",
        :created_on => Mon, 26 Aug 2019 18:55:58 UTC +00:00,
        :updated_on => Mon, 26 Aug 2019 18:55:58 UTC +00:00,
      :lock_version => 0,
           :task_id => nil,
        :deliver_on => nil,
        :queue_name => "generic",
        :class_name => "ManageIQ::Providers::Vmware::InfraManager::Vm",
       :instance_id => 1,
              :args => [],
      :miq_callback => {
         :class_name => "MiqTask",
        :instance_id => 435627,
        :method_name => :queue_callback,
               :args => [
            [0] "Finished"
        ]
    },
          :msg_data => nil,
              :zone => nil,
              :role => "automate",
       :server_guid => nil,
       :msg_timeout => 600,
        :handler_id => nil,
      :handler_type => nil,
        :expires_on => nil,
    :tracking_label => nil,
           :user_id => 1,
          :group_id => 2,
         :tenant_id => 1,
       :miq_task_id => 435627
}

[lfu]

cc @d-m-u

[d-m-u]

So, doesn't resource_search handle the case where the id isn't present?

[lpichler]

yes you are right 👍

[d-m-u]

And this is a stupid nit, sorry, but you have a typo here, vm not vn

[lpichler]

done 👍

[d-m-u]

this is great, thank you!!

[abellotti]

in above expectations of api urls, would prefer usage of rails helper methods, i.e. a_string_matching(api_vm_url(nil, vm))

[lpichler]

@abellotti sure, I changed it, thanks!

[miq-bot]

Checked commit lpichler@b29fd91 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[abellotti]

Thanks you @lpichler for the fix and update. LGTM!! 👍

will merge when green.

[ghost]

Shouldn't it be tagged as ivanchuk/yes ?

[lpichler]

Shouldn't it be tagger as ivanchuk/yes ?

Can you confirm it @lfu , please ?

I guess that ManageIQ/manageiq#19064 is in ivanchuk. so I think that you are right. thanks @fdupont-redhat

@miq-bot add_label ivanchuk/yes

[lfu]

@lpichler Thanks for the fix!
ManageIQ/manageiq#19064 is hammer/yes and ivanchuk/yes. The same should be applied to this commit.

[lpichler]

@lfu thanks also for you help with this fix.

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 4ff6a9ccef4ced348912f31ebb6836f97fd51f62
Author: Alberto Bellotti <[email protected]>
Date:   Tue Aug 27 10:20:04 2019 -0400

    Merge pull request #662 from lpichler/do_policy_check_before_retiring_request

    (CI Failure Fix ) Put make_retire_request on queue in VmsController

    (cherry picked from commit d3b5c8edb74b606f8e57c9928ca7dfd90fa31118)

[simaishi]

Hammer backport details:

$ git log -1
commit 0df1575a0d689330090c243f94bd34ee0f9ea821
Author: Alberto Bellotti <[email protected]>
Date:   Tue Aug 27 10:20:04 2019 -0400

    Merge pull request #662 from lpichler/do_policy_check_before_retiring_request

    (CI Failure Fix ) Put make_retire_request on queue in VmsController

    (cherry picked from commit d3b5c8edb74b606f8e57c9928ca7dfd90fa31118)