Support firmware update

app/controllers/api/physical_servers_controller.rb

@@ -1,6 +1,7 @@
 module Api
   class PhysicalServersController < BaseController
     include Subcollections::EventStreams
+    include Subcollections::FirmwareBinaries
 
     def blink_loc_led_resource(type, id, _data)
       change_resource_state(:blink_loc_led, type, id)

app/controllers/api/subcollections/firmware_binaries.rb

@@ -0,0 +1,9 @@
+module Api
+  module Subcollections
+    module FirmwareBinaries
+      def firmware_binaries_query_resource(object)
+        object.compatible_firmware_binaries
+      end
+    end
+  end
+end

config/api.yml

@@ -1225,6 +1225,16 @@
       :post:
       - :name: assign
       - :name: unassign
+  :firmware_binaries:
+    :description: Firmware Binaries
+    :options:
+    - :subcollection
+    :verbs: *g
+    :klass: FirmwareBinary
+    :subcollection_actions:
+      :get:
+      - :name: read
+        :identifier: firmware
   :firmwares:
     :description: Firmwares
     :options:
@@ -1244,6 +1254,7 @@
       :get:
       - :name: read
         :identifier: firmware_show
+
   :flavors:
     :description: Flavors
     :identifier: flavor
@@ -1931,6 +1942,7 @@
     :klass: PhysicalServer
     :subcollections:
     - :event_streams
+    - :firmware_binaries
     :collection_actions:
       :get:
       - :name: read
@@ -2647,6 +2659,8 @@
           :identifier: vm_retire
         - :klass: PhysicalServerProvisionRequest
           :identifier: physical_server_provision
+        - :klass: PhysicalServerFirmwareUpdateRequest
+          :identifier: firmware
       - :name: edit
         :identifier: miq_request_edit
       - :name: approve

spec/requests/physical_servers_spec.rb

@@ -622,5 +622,40 @@
         end
       end
     end
+
+    describe 'FirmwareBinaries subcollection' do
+      let(:physical_server) { FactoryBot.create(:physical_server, :with_asset_detail) }
+      let(:firmware_binary) { FactoryBot.create(:firmware_binary) }
+      let!(:firmware_target) do
+        FactoryBot.create(
+          :firmware_target,
+          :manufacturer      => physical_server.asset_detail.manufacturer,
+          :model             => physical_server.asset_detail.model,
+          :firmware_binaries => [firmware_binary]
+        )
+      end
+
+      describe 'GET /api/physical_servers/:id/firmware_binaries' do
+        let(:url) { api_physical_server_firmware_binaries_url(nil, physical_server) }
+
+        it 'returns the firmware_binaries with an appropriate role' do
+          api_basic_authorize subcollection_action_identifier(:physical_servers, :firmware_binaries, :read, :get)
+          get(url)
+          expect_result_resources_to_include_hrefs(
+            'resources',
+            [
+              api_physical_server_firmware_binary_url(nil, physical_server, firmware_binary)
+            ]
+          )
+          expect(response).to have_http_status(:ok)
+        end
+
+        it 'does not return the event_streams without an appropriate role' do
+          api_basic_authorize
+          get(url)
+          expect(response).to have_http_status(:forbidden)
+        end
+      end
+    end
   end
 end