Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add endpoints subcollections #584

Closed

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented May 6, 2019

POST http://localhost:3000/api/providers

{"name":"Test azure1","type":"ManageIQ::Providers::Azure::CloudManager","credentials":{"userid":"foo","password":"bar"},"endpoints":[{"url":"www.endpoints.com"}]}

cc @Hyperkid123

@miq-bot miq-bot added the wip label May 6, 2019
@miq-bot
Copy link
Member

miq-bot commented May 6, 2019

Checked commit lpichler@47ca889 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 3 offenses detected

app/controllers/api/subcollections/endpoints.rb

config/api.yml

  • ⚠️ - Line 36, Col 7 - indentation - wrong indentation: expected 4 but found 6
  • ⚠️ - Line 41, Col 9 - indentation - wrong indentation: expected 6 but found 8

@Hyperkid123
Copy link
Contributor

@lpichler

Ok so i found more sub-collections and another relations that we will need to create/edit providers via API

  • connection_configurations
    • this is required for openstack and wmvare cloud providers
    • its similar to endpoints, in fact it connections are listed inside endpoints
    • according to API docs you should be able to create entity with this sub-collection but you cannot expand it
    • this should include these connections for cloud providers:
      • endpoints
      • amqp
      • ssh key pair
  • authentication_userid
    • is required for editing amazon/azure connection
  • keystone_v3_domain_id
    • required for adding/editing OpenStack cloud provider

@lpichler
Copy link
Contributor Author

lpichler commented Oct 7, 2019

closing as discussed with @Hyperkid123 there is work in progress about it.

@lpichler lpichler closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants