[WIP] Deprecate category #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
deprecate_category
branch
2 times, most recently
from
0c3db2d to
b51a9bd
Compare
2 tasks
kbrock
force-pushed
the
deprecate_category
branch
3 times, most recently
from
d359a07 to
7fc8c01
Compare
|
wip: deleting category from models and ensuring this still works. will be non-wip soon |
When we reference category, we are really talking about a classification
WIP: This causes some test failures. I'm wondering if we created Category to get around limitations in the api
kbrock
force-pushed
the
deprecate_category
branch
from
7fc8c01 to
ae15101
Compare
|
Checked commits kbrock/manageiq-api@5ae60ba~...ae15101 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Category was created to make API easier - going to let it live on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ManageIQ/manageiq#17210
Removing
Categoryfrom app/models.rbIt is just a child of
Classificationwith adefault scope { where(:parent_id => 0) }So there is not much lost.
Also, in anticipation of removing
Tagclass (merging withClassification), I changed tests to referenceClassificationinstead ofTagwhere possible.