Use wrapped Rails request helpers instead of custom ones #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, the new syntax. I'll see if I can do something about that. @miq-bot add-label wip |
imtayadeway
force-pushed
the
patch-session-process
branch
2 times, most recently
from
cb04833 to
b3dec52
Compare
imtayadeway
force-pushed
the
patch-session-process
branch
from
b3dec52 to
f79513c
Compare
|
@miq-bot rm-label wip |
imtayadeway
changed the title
imtayadeway
changed the title
imtayadeway
changed the title
imtayadeway
force-pushed
the
patch-session-process
branch
from
e5e7d02 to
b23dbfc
Compare
imtayadeway
force-pushed
the
patch-session-process
branch
from
b23dbfc to
aa22270
Compare
Creates a `RequestHelpers` module in a distinct `Spec::Support::Api` namespace (and moves the `ApiHelper` in there for consistency) with patched versions of the request helpers provided by Rails.
imtayadeway
force-pushed
the
patch-session-process
branch
from
aa22270 to
0fdf463
Compare
|
Checked commits imtayadeway/manageiq-api@53ca003~...0fdf463 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chrisarcand
approved these changes
Sep 14, 2017
There was a problem hiding this comment.
Paired on this with @imtayadeway and happy with the results 👍 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By wrapping
Session#processto do a little extra work for us (namely defaulting to:as => :jsonfor PUT/PATCH/POST and merging in the request headers that are created by thebasic_authorizemethod), therun_get,run_post, etc. helpers become transparent wrappers for the request helpers provided by Rails, meaning that we can simply use those ones instead. I think this will provide a better experience for new contributors who will be more familiar with these helpers (if they are a Rails developer).@miq-bot add-label refactoring, test
@miq-bot assign @abellotti