Ensure ServiceTemplate ordering passes through the submit_workflow flag #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit eclarizio@f5ff338 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
approved these changes
Oct 30, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2018
…_addendum Ensure ServiceTemplate ordering passes through the submit_workflow flag (cherry picked from commit bed1032) https://bugzilla.redhat.com/show_bug.cgi?id=1632416
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
…_addendum Ensure ServiceTemplate ordering passes through the submit_workflow flag (cherry picked from commit bed1032) https://bugzilla.redhat.com/show_bug.cgi?id=1646435
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I made #476, #485 got merged before it, and I overlooked an issue where the
submit_workflowflag was not being set correctly, causing issues when submitting requests directly through the API instead of the UI. When the backend attempts to validate the dialog, the correct values that were passed through the request are not loaded without thesubmit_workflowflag set.https://bugzilla.redhat.com/show_bug.cgi?id=1632416
@miq-bot add_label bug, hammer/yes, gaprindashvili/yes
@miq-bot add_reviewer @d-m-u
@miq-bot assign @bdunne