Post body changes for validate_vms_resource to include service template_id
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the edit ServiceTemplate record use case where we need to specify the id of the ServiceTemplate record
|
@miq-bot add_label hammer/yes |
|
@bdunne Can you review this? ManageIQ/manageiq#18065 was just merged after which I restarted Travis here. |
bdunne
requested changes
Oct 24, 2018
| transformation_mapping = | ||
| FactoryGirl.create(:transformation_mapping, | ||
| :transformation_mapping_items => [TransformationMappingItem.new(:source => source_ems, :destination => destination_ems)]) | ||
| vm = FactoryGirl.create(:vm_vmware, :name => 'test_vm', :ems_cluster => source_ems, :ext_management_system => FactoryGirl.create(:ext_management_system)) |
There was a problem hiding this comment.
Please don't set name as there's a sequencer for it.
There was a problem hiding this comment.
Should one of the clusters above (assuming it's supposed to be a cluster) be connected to this ext_management_system?
| transformation_mapping = | ||
| FactoryGirl.create(:transformation_mapping, | ||
| :transformation_mapping_items => [TransformationMappingItem.new(:source => source_ems, :destination => destination_ems)]) | ||
| vm = FactoryGirl.create(:vm_vmware, :name => 'test_vm', :ems_cluster => source_ems, :ext_management_system => FactoryGirl.create(:ext_management_system)) |
| context "can validate vms with csv data and service_template_id are specified" do | ||
| it "vm belongs to the service_template record" do | ||
| api_basic_authorize(action_identifier(:transformation_mappings, :validate_vms, :resource_actions, :post)) | ||
| source_ems = FactoryGirl.create(:ems_cluster) |
There was a problem hiding this comment.
Is this supposed to be an EMS or a cluster? Please adjust the factory or variable name accordingly.
|
|
||
| it "vm does not belong to the service_template record" do | ||
| api_basic_authorize(action_identifier(:transformation_mappings, :validate_vms, :resource_actions, :post)) | ||
| source_ems = FactoryGirl.create(:ems_cluster) |
|
Checked commits AparnaKarve/manageiq-api@9936e46~...569bc98 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bdunne Addressed your feedback for improving readability in the tests. |
bdunne
approved these changes
Oct 24, 2018
simaishi
pushed a commit
that referenced
this pull request
Oct 25, 2018
…_service_template_id Post body changes for `validate_vms_resource ` to include service template_id (cherry picked from commit 93b07cd)
|
Hammer backport details: |
AparnaKarve
deleted the
post_body_changes_to_include_service_template_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on ManageIQ/manageiq#18065
Fixes ManageIQ/manageiq-v2v#677
(Tests are expected to fail until ManageIQ/manageiq#18065 is merged)