-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the replacement backend method for searching and valiating VMs #463
Use the replacement backend method for searching and valiating VMs #463
Conversation
@abellotti @gtanzillo Can you recommend an assignee for this? @miq-bot add_label enhancement, transformation |
@AparnaKarve Can you address the Travis failure? Thanks. |
@lfu The Travis failure is related to the fact that ManageIQ/manageiq#17364 is still not merged. |
@AparnaKarve @lfu Please see failing tests after core PR merged. |
34e836c
to
eab7421
Compare
eab7421
to
96bf314
Compare
Checked commits AparnaKarve/manageiq-api@d03f754~...96bf314 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@gmcculloug @lfu Fixed the tests @abellotti This should be good to go |
are we ok with the changed signature coming back from the method/thus REST API ? Aren't current callers be broken ? |
Only caller today would be ManageIQ/manageiq-v2v#618. @AparnaKarve Can you confirm that you are expecting these keys to change? |
@abellotti As Greg mentioned above, v2v is the only caller. In ManageIQ/manageiq-v2v#618 I have taken into account the changed signature coming back from the API/method. |
@abellotti Can we merge this today? |
This PR basically replaces
validate_vms
withsearch_vms_and_validate
To be merged after ManageIQ/manageiq#17364 is merged