Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the replacement backend method for searching and valiating VMs #463

Merged

Conversation

AparnaKarve
Copy link
Contributor

This PR basically replaces validate_vms with search_vms_and_validate

To be merged after ManageIQ/manageiq#17364 is merged

@gmcculloug
Copy link
Member

@abellotti @gtanzillo Can you recommend an assignee for this?

@miq-bot add_label enhancement, transformation

@lfu
Copy link
Member

lfu commented Sep 18, 2018

@AparnaKarve Can you address the Travis failure? Thanks.

@AparnaKarve
Copy link
Contributor Author

@lfu The Travis failure is related to the fact that ManageIQ/manageiq#17364 is still not merged.
Once it gets merged, we should re-run Travis here, and bring it to green.

@gmcculloug
Copy link
Member

@AparnaKarve @lfu Please see failing tests after core PR merged.

@AparnaKarve AparnaKarve reopened this Sep 20, 2018
@AparnaKarve AparnaKarve force-pushed the use_method_search_vms_and_validate branch from 34e836c to eab7421 Compare September 20, 2018 15:54
@AparnaKarve AparnaKarve force-pushed the use_method_search_vms_and_validate branch from eab7421 to 96bf314 Compare September 20, 2018 16:12
@miq-bot
Copy link
Member

miq-bot commented Sep 20, 2018

Checked commits AparnaKarve/manageiq-api@d03f754~...96bf314 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@AparnaKarve
Copy link
Contributor Author

@gmcculloug @lfu Fixed the tests

@abellotti This should be good to go

@abellotti
Copy link
Member

are we ok with the changed signature coming back from the method/thus REST API ? Aren't current callers be broken ?

@gmcculloug
Copy link
Member

Only caller today would be ManageIQ/manageiq-v2v#618.

@AparnaKarve Can you confirm that you are expecting these keys to change?

@AparnaKarve
Copy link
Contributor Author

@abellotti As Greg mentioned above, v2v is the only caller.

In ManageIQ/manageiq-v2v#618 I have taken into account the changed signature coming back from the API/method.

@AparnaKarve
Copy link
Contributor Author

@abellotti Can we merge this today?
Without this PR and ManageIQ/manageiq-v2v#618, v2v would be broken in the nightly build tonight.

@abellotti abellotti self-requested a review September 20, 2018 20:06
@abellotti abellotti self-assigned this Sep 20, 2018
@abellotti abellotti added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 20, 2018
@abellotti abellotti merged commit ec0a7e5 into ManageIQ:master Sep 20, 2018
@AparnaKarve AparnaKarve deleted the use_method_search_vms_and_validate branch September 20, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants