Set the cred.manager to an EMS not a Provider #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credentials created by EmsRefresh set the credential.manager to the AutomationManager not a Provider. This causes issues where credential.manager is expected to be an ExtManagementSystem type.
This was referenced Aug 19, 2018
|
Checked commit kbrock@4bfb191 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
All remaining failures are solved by #447 |
|
Cc @gtanzillo |
gtanzillo
approved these changes
Aug 20, 2018
|
Merged as part of #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by ManageIQ/manageiq#17531 (but failure is actually due to a bad spec)
Credentials created by EmsRefresh set the credential.manager to the
AutomationManager not a Provider. This causes issues where
credential.manager is expected to be an ExtManagementSystem type.
Fixing test failures 99% stolen from: