Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing specs due to model name in exception #446

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 6, 2018

ManageIQ/manageiq#17754 added a prefixed model
name in a number of exceptions which is causing a few specs to fail
which were matching on the raised exception.

ManageIQ/manageiq#17754 added a prefixed model
name in a number of exceptions which is causing a few specs to fail
which were matching on the raised exception.
@agrare
Copy link
Member Author

agrare commented Aug 6, 2018

@miq-bot assign @abellotti
@miq-bot add-label test

@miq-bot
Copy link
Member

miq-bot commented Aug 6, 2018

Checked commit agrare@306615d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@abellotti abellotti self-requested a review August 6, 2018 14:57
@abellotti abellotti added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 6, 2018
@abellotti abellotti merged commit 0c8ed89 into ManageIQ:master Aug 6, 2018
@agrare agrare deleted the fix_specs_failing_on_added_model_prefix branch August 6, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants