Use the new universal methods for suspending/resuming a provider

[skateman]

Parent issue: ManageIQ/manageiq#17489
Depends on: ManageIQ/manageiq#17452

cc @slemrmartin

https://bugzilla.redhat.com/show_bug.cgi?id=1455145

[slemrmartin]

👍 LGTM

[skateman]

@slemrmartin are these methods still safe to use?

[slemrmartin]

@skateman yes, pause! and resume! are still entry points for this PR

[miq-bot]

Checked commit skateman@cc4dd1b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[juliancheal]

👍 LGTM.

[jvlcek]

@skateman Since the goal is to try to have every PR include a related spec test perhaps you could update https://github.com/ManageIQ/manageiq-api/blob/master/spec/requests/providers_spec.rb to ensure the new methods are received.

It shouldn't be too hard to add.

Besides that 👍 LGTM

[skateman]

@jvlcek there are already tests for this feature, I'm just changing the method to be called on the model. So I don't really understand what else should I test here, can you please clarify?

[jvlcek]

@skateman Understood and agreed. I was just thinking that maybe an
expect(X).to receive(:pause!) could be added to the pause a provider test but on second thought it's not overly valuable.

I'm OK with this PR as it is.

JoeV