Added verify_ssl to the list of valid attributes #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we add a provider it might be using self signed certs We need a way to disable the certificate check with verify_ssl. The UI provides a check box to disable certifcate check we would need something similar for REST API
|
@bdunne @abellotti |
|
Checked commit mkanoor@fb0b2fc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
is verify_ssl for all or specific to the provider you're working with ? note, providers can also tell us their specific attributes via the api_allowed_attributes method. |
bdunne
approved these changes
Jul 26, 2018
|
I restarted the tests after #432 was merged, but I think this will need a rebase or at least a close / reopen to get the tests passing. |
abellotti
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add a provider it might be using self signed certs
We need a way to disable the certificate check with verify_ssl.
The UI provides a check box to disable certifcate check we would
need something similar for REST API