Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #15472 from isimluk/CVE-2016-7047-final" #31

Closed
wants to merge 1 commit into from

Conversation

imtayadeway
Copy link
Contributor

This reverts commit 6fa7373, reversing
changes made to e8d3020.

Conflicts:
spec/requests/reports_spec.rb

This is a more drastic solution to https://bugzilla.redhat.com/show_bug.cgi?id=1479296. Prefer #30 first.

@miq-bot add-label bug
@miq-bot assign @abellotti
/cc @gtanzillo @yrudman

This reverts commit 6fa7373, reversing
changes made to e8d3020.

Conflicts:
        spec/requests/reports_spec.rb
@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2017

Some comments on commit imtayadeway@5b413ed

spec/requests/reports_spec.rb

  • ⚠️ - 104 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 71 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2017

Checked commit imtayadeway@5b413ed with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

@imtayadeway
Copy link
Contributor Author

Closing as I've verified that #30 works

@imtayadeway imtayadeway deleted the revert-15472 branch January 12, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants