Update dialog copy product feature #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f460c4628a4dcac0803e306c31d63c2055934e7 in the main repository changed the name of this product feature, breaking the contract between product features and the API. This PR updates the API to be back in sync. Links: ManageIQ/manageiq#16623
|
was 1f460c4628a4dcac0803e306c31d63c2055934e7 backported to G-release ? I see this PR here g/yes. |
|
@abellotti if you look at the linked PR it is marked as gaprindashvili/backported |
|
Thanks. This LGTM!! 🎵 waiting on 🍏 |
abellotti
approved these changes
Jan 5, 2018
|
Checked commit imtayadeway@a499e85 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 5, 2018
Update dialog copy product feature (cherry picked from commit c4e2c09) https://bugzilla.redhat.com/show_bug.cgi?id=1531297
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f460c4628a4dcac0803e306c31d63c2055934e7 in the main repository
changed the name of this product feature, breaking the contract
between product features and the API. This PR updates the API to be
back in sync.
This should restore the failing master build.
/cc @romanblanco @dclarizio @himdel
Links: ManageIQ/manageiq#16623