Remove remaining decorators from the API #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of the supported_consoles virtual attribute on the VMs model, there is no longer a need to maintain the last remaining decorators in the API.
|
Checked commit jntullo@7a66f39 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
chrisarcand
approved these changes
Dec 5, 2017
|
@jntullo I'm good with this 👍 , before this gets merged can we get a quick check that SUI/Classic-UI does not use this any longer ? Thanks. We also allow decorators in the manageiq-api CLI, but that's ok to keep as we may use the CLI to access an earlier server. |
|
SUI sounding off here we're g2g no decorators are present in master! (or anywhere else, but this is for master) |
abellotti
approved these changes
Dec 5, 2017
|
I don't see any references in the Classic UI either - they used the decorators directly, not via the API. |
|
Thanks @AllenBW for checking for SUI. did a quick grep in classic ui, no decorators there either. Thanks. |
AllenBW
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the
supported_consolesvirtual attribute on the VMs model, there is no longer a need to maintain the last remaining decorators in the API.@miq-bot add_label cleanup