require credentials when creating a provider #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jntullo Cannot apply the following label because they are not recognized: bz |
|
Checked commit jntullo@a6ce25d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM!!! Thanks @jntullo 👍 |
|
@jntullo @abellotti Can/should this be backported to Fine branch? The associated BZ has the backport flag set. |
|
@jntullo @abellotti ^ ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manageiq-apiversion of ManageIQ/manageiq#15528Currently, credentials are not required when creating a new provider via the api, which differs from the Classic UI which requires that credentials be added. This PR makes credentials required if there are no connection attributes specified (container providers only supply connection attributes)
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1467692
@miq-bot assign @abellotti