Return correct href for collections on Index

[jntullo]

Fixes issues where the API prefix isn't passed back in the API index for collections

@miq-bot add_label bug
@miq-bot assign @abellotti

[imtayadeway]

WDYT of doing something like this for the verification here:

      collection_names = Api::ApiConfig.collections.to_h.select { |_, v| v.options.include?(:collection) }.keys
      hrefs = collection_names.collect { |name| url_for(:controller => name, :action => "index") }
      expected = {
        "collections" => a_collection_containing_exactly(
          *hrefs.collect { |href| a_hash_including("href" => href) }
        )
      }
      expect(response.parsed_body).to include(expected)

Aithough there's a bit more going on there, I like it because:

1. It verifies against an external source of truth (if for instance there were no collections in your response, you'd still pass)
2. It looks for an exact match on the href
3. It's a single expectation, which will give you one failure and a diff in the event of a regression

[miq-bot]

Checked commit jntullo@ce89f6e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[abellotti]

Thanks @jntullo for fixing this.