Skip to content

Commit

Permalink
Merge pull request #677 from lpichler/remove_useless_param_methods_fr…
Browse files Browse the repository at this point in the history
…om_ResultsController

Remove useless param methods in ResultsController
  • Loading branch information
abellotti authored Sep 27, 2019
2 parents d0e923a + 2df2287 commit 2ba3096
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions app/controllers/api/base_controller/parameters.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,7 @@ def param_result_set?
end

def report_options
params.merge(:sort_by => params['sort_by'], :sort_order => sort_order).merge(filter_options)
end

def filter_options
filtering_enabled? ? {:filter_string => params[:filter_string], :filter_column => params[:filter_column]} : {}
end

def filtering_enabled?
params.key?(:filter_column) && params.key?(:filter_string) && params[:filter_string]
params.merge(:sort_order => sort_order)
end
end

Expand Down

0 comments on commit 2ba3096

Please sign in to comment.