Only allow service ordering when the product setting is enabled

https://bugzilla.redhat.com/show_bug.cgi?id=1632416

app/controllers/api/mixins/service_templates.rb

@@ -3,7 +3,9 @@ module Mixins
     module ServiceTemplates
       def order_service_template(id, data, scheduled_time = nil)
         service_template = resource_search(id, :service_templates, ServiceTemplate)
-        raise BadRequestError, "#{service_template_ident(service_template)} cannot be ordered" unless service_template.orderable?
+        unless api_request_allowed? && service_template.orderable?
+          raise BadRequestError, "#{service_template_ident(service_template)} cannot be ordered"
+        end
         request_result = service_template.order(User.current_user, (data || {}), {:submit_workflow => true}, scheduled_time)
         errors = request_result[:errors]
         if errors.present?
@@ -17,6 +19,15 @@ def order_service_template(id, data, scheduled_time = nil)
       def service_template_ident(st)
         "Service Template id:#{st.id} name:'#{st.name}'"
       end
+
+      def api_request_allowed?
+        return true if request_from_ui?
+        Settings.product.allow_api_service_ordering
+      end
+
+      def request_from_ui?
+        !request.authorization.try(:downcase).try(:starts_with?, "basic")
+      end
     end
   end
 end

spec/requests/service_templates_spec.rb

@@ -576,6 +576,32 @@
         expect(actions).to_not include("order")
       end
     end
+
+    context "with the product setting not allowing standalone service template ordering" do
+      let(:template_no_display) { FactoryGirl.create(:service_template, :display => false) }
+      let(:product_settings) { double(:allow_api_service_ordering => false) }
+
+      before do
+        stub_settings_merge(:product => product_settings)
+      end
+
+      context "with basic authorization" do
+        it "rejects the request" do
+          api_basic_authorize action_identifier(:service_templates, :order, :resource_actions, :post)
+
+          post(api_service_template_url(nil, template_no_display), :params => { :action => "order" })
+
+          expected = {
+            "error" => a_hash_including(
+              "kind"    => "bad_request",
+              "message" => /cannot be ordered/
+            )
+          }
+          expect(response).to have_http_status(:bad_request)
+          expect(response.parsed_body).to include(expected)
+        end
+      end
+    end
   end
 
   describe "Service Templates archive" do