-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update http gem to 3.0+ #321
Conversation
Only breaking change is drop of support for ruby 2.0 and 2.1 which we don't care. Fixes ManageIQ#320
Tests for ruby 2.2 passed, but failed for 2.3, 24 and 2.5 :( |
possibly related: vcr/vcr#695 (similar error, with http gem). |
also sounds like this was supposed to be fixed in http 3.2.1 by httprb/http#468? |
Close-cycling to rerun Travis in vague hope failures would go away (?) 😉 UPDATE: no, fails all rubies |
Whoah, this is sporadic, depends on test order! |
Can you also relax webmock to |
from ~> 3.0.1 to ~> 3.0
@cben relaxed webmock as well and now tests are passing. |
Thanks! Have you by chance done any real-life testing of watching with http 3? [P.S. My response speed is not good lately. And Mooli switched to a new job and likely won't have time for kubeclient. I'd be happy if anyone wants to join as maintainer.] |
👍 Tested watching manually, seems fine (with http 3.3.0 which is current version this PR gets). Merging. (Should we also allow http 2.y? 3.y exists for over a year, so I feel OK dropping 2.y — if someone needs it let us know, it's not impossible) |
Only breaking change is drop of support for ruby 2.0 and 2.1 which we don't care. Fixes #320
twitter gem already moved to http 3.0 and this will help in debian packaging. We prefer to maintain only a single version of http.