Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove targeted arel option #73

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Apr 4, 2019

It is no longer used

Depends on:

@Ladas Ladas added the cleanup label Apr 4, 2019
@Ladas Ladas force-pushed the remove_targeted_arel_option branch from a8b1ef0 to e3d48d7 Compare April 4, 2019 15:37
@Ladas Ladas mentioned this pull request Apr 4, 2019
1 task
@Ladas Ladas force-pushed the remove_targeted_arel_option branch from e3d48d7 to be4777c Compare April 4, 2019 15:41
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2019

This pull request is not mergeable. Please rebase and repush.

It is no longer used
@Ladas Ladas force-pushed the remove_targeted_arel_option branch from be4777c to df68936 Compare April 5, 2019 12:36
@Ladas Ladas removed the unmergeable label Apr 5, 2019
@miq-bot
Copy link
Member

miq-bot commented Apr 5, 2019

Checked commit Ladas@df68936 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

lib/inventory_refresh/inventory_collection/builder.rb

@agrare agrare merged commit 8a01f01 into ManageIQ:master Apr 5, 2019
d-m-u added a commit to d-m-u/inventory_refresh that referenced this pull request Jun 29, 2020
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
d-m-u added a commit to d-m-u/inventory_refresh that referenced this pull request Jul 14, 2020
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
agrare added a commit to agrare/inventory_refresh that referenced this pull request Feb 3, 2022
…l_option"

This reverts commit 8a01f01, reversing
changes made to 4da01ad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants