Fix the broken test matrix and drop old rubies and rails (breaking change) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ci.yaml matrix of rubies and rails versions didn't match the case statement in the Gemfile. Rails 7.0 and 7.1 were not included in the case statement previously. Now, we sync them up and make the following changes: Drop: * ruby 2.7 * rails 6.0 * rails 6.1 Add: * ruby 3.3 * rails 7.2 We set a minimum ruby version of 3.0 and rails 7.0.8 and allow versions less than 8.0, so we can test with 7.1 and 7.2.
|
ooh, it's failing on rails 7.2 reasons... first one! |
See: https://www.github.com/rails/rails/pull/47354 For now, we can maintain support for 7.0-7.2 by manually instantiating the object and not pass an explicit deprecator.
Looks like they removed the automatic access to the singleton instance of the deprecation class. Updated the code and description. |
This was referenced Sep 25, 2024
|
I think this is ready to go. |
agrare
approved these changes
Sep 29, 2024
agrare
added a commit
that referenced
this pull request
Sep 30, 2024
Changes: - Drop old versions of ruby and rails, add ruby 3.3 and rails 7.2 (#139)
jrafanie
deleted the
fix_broken_test_matrix_and_drop_old_rubies_rails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the broken test matrix and drop old rubies and rails
The ci.yaml matrix of rubies and rails versions didn't match the case statement in the Gemfile. Rails 7.0 and 7.1 were not included in the case statement previously.
Now, we sync them up and make the following changes:
Drop:
Add:
We set a minimum ruby version of 3.0 and rails 7.0.8 and allow versions less than 8.0, so we can test with 7.1 and 7.2.
Rails 7.1 deprecated and 7.2 removed access to the deprecator instance
See: https://www.github.com/rails/rails/pull/47354
For now, we can maintain support for 7.0-7.2 by manually instantiating the object
and not pass an explicit deprecator.