Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 keyword arguments #109

Merged
merged 5 commits into from
May 2, 2022
Merged

Ruby 3 keyword arguments #109

merged 5 commits into from
May 2, 2022

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 29, 2022

This is #98 rebased to master (vs v02)

kept it separate to double check nothing was lost.

@kbrock kbrock added the ruby3 label Apr 29, 2022
@kbrock kbrock requested review from agrare and Fryguy as code owners April 29, 2022 20:24
@kbrock
Copy link
Member Author

kbrock commented Apr 29, 2022

I can fix normalcase for variables for just these lines, or for the whole file.
let me know if you want to incur the churn

@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2022

Checked commits kbrock/inventory_refresh@ef5122e~...1c7b4f1 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
10 files checked, 6 offenses detected

spec/save_inventory/acyclic_graph_of_inventory_collections_spec.rb

@kbrock
Copy link
Member Author

kbrock commented Apr 29, 2022

update:

  • updated matrix
  • updated cops indentation

@agrare agrare merged commit 23d3bda into ManageIQ:master May 2, 2022
@kbrock kbrock deleted the ruby3 branch May 2, 2022 13:49
agrare added a commit that referenced this pull request May 3, 2022
Added
- Ruby 3 support (#109)
- Cron for GitHub Actions (#108)
@agrare
Copy link
Member

agrare commented May 3, 2022

Released v1.1.0 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants