Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix for test_service_rbac #9999

Merged
merged 1 commit into from
Mar 27, 2020
Merged

[1LP][RFR] Fix for test_service_rbac #9999

merged 1 commit into from
Mar 27, 2020

Conversation

Gauravtalreja1
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 commented Mar 19, 2020 •
edited
Loading

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_service_rbac.py --long-running }}

@dajoRH dajoRH added lint-ok and removed needs-lint labels Mar 20, 2020
@Gauravtalreja1 Gauravtalreja1 force-pushed the fix-rbac-service branch 7 times, most recently from bef914b to 3f3ead7 Compare March 26, 2020 09:31
@Gauravtalreja1 Gauravtalreja1 changed the title [WIPTEST] Fix for test_service_rbac [RFR] Fix for test_service_rbac.py Mar 26, 2020
jarovo
jarovo approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@jarovo jarovo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no problem with this PR, but I think others would like you to use delete_if_exists

john-dupuy
john-dupuy suggested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes about using delete_if_exists, otherwise LGTM

@john-dupuy john-dupuy changed the title [RFR] Fix for test_service_rbac.py [WIPTEST] Fix for test_service_rbac.py Mar 26, 2020
@Gauravtalreja1 Gauravtalreja1 changed the title [WIPTEST] Fix for test_service_rbac.py [RFR] Fix for test_service_rbac Mar 26, 2020
@john-dupuy john-dupuy changed the title [RFR] Fix for test_service_rbac [1LP][RFR] Fix for test_service_rbac Mar 26, 2020
digitronik
digitronik reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR 👍
Thanks for fix... one question take a look.

@digitronik digitronik merged commit 80b03c5 into ManageIQ:master Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jarovo jarovo jarovo approved these changes

@digitronik digitronik digitronik approved these changes

@john-dupuy john-dupuy john-dupuy approved these changes

Assignees
No one assigned
Labels
fix-test lint-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gauravtalreja1 @jarovo @digitronik @john-dupuy @dajoRH