This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Adding multi_drop down service dialog test #9996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyazRedhat
changed the title
niyazRedhat
changed the title
valaparthvi
suggested changes
Mar 18, 2020
Comment on lines
1012
to
1015
| assert "One" and "Two" and "Three" in[ | ||
| option.text for option in view.fields(ele_label).multi_drop.all_options] | ||
| assert "<None>" not in [ | ||
| option.text for option in view.fields(ele_label).multi_drop.all_options] |
There was a problem hiding this comment.
This condition will not check what you want to check.
The condition here will only fail if Three is not in the list.
You can do this instead -
Suggested change
| assert "One" and "Two" and "Three" in[ | |
| option.text for option in view.fields(ele_label).multi_drop.all_options] | |
| assert "<None>" not in [ | |
| option.text for option in view.fields(ele_label).multi_drop.all_options] | |
| options_list = [option.text for option in view.fields(ele_label).multi_drop.all_options] | |
| assert all([opt in options_list for opt in ["One", "Two", "Three"]]) | |
| assert "<None>" in options_list |
| @@ -1003,20 +1003,16 @@ def test_dialog_dropdown_integer_required(): | |||
| casecomponent: Services | |||
| initialEstimate: 1/16h | |||
| startsin: 5.10 | |||
| testSteps: | |||
There was a problem hiding this comment.
Why did you remove testSteps and expectedResults?
niyazRedhat
force-pushed
the
bz_1740823_dropdwn
branch
from
4b0ec72
to
6b48023
Compare
valaparthvi
approved these changes
Mar 18, 2020
valaparthvi
changed the title
digitronik
approved these changes
Mar 24, 2020
| view = navigate_to(service_catalogs, "Order") | ||
|
|
||
| options_list = [option.text for option in view.fields(ele_label).multi_drop.all_options] | ||
| assert all([opt in options_list for opt in ["One", "Two", "Three"]]) |
There was a problem hiding this comment.
I would try to use set operation here.
assert set(options_list) == {'One', 'Two', 'Three'}
mshriver
added
the
test-automation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_multi_dropdown_dialog_value }}