-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Adding ec2 service stack test #9991
Conversation
testSteps: | ||
1. create an aws template with an optional value "timeout" | ||
2. create a dialog that will offer an option to overwrite "timeout" | ||
with a custom value typed at input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is step 1 and 2 happening ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshveta from orchestration file we create the template and as per yaml data it gives the dialog input field in order page https://github.com/ManageIQ/integration_tests/tree/master/data/orchestration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR single comment
3. | ||
4. the value input should be passed | ||
""" | ||
msg = "<AEMethod groupsequencecheck> dialog_stack_timeout: 20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niyazRedhat I think better to use regular expression for such match. I'm suspect about whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its okay here without it because there is no backslash, but for future use @niyazRedhat, its good to use the syntax for the string that includes an 'r' r"<some-regex-string>"
.
This is a stringprefix in python, part of the string literal definition. It stands for raw
string (not regex string) and will treat the backslashes regularly used in regex as literal.
https://docs.python.org/3.7/reference/lexical_analysis.html#grammar-token-stringprefix
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_provision_stack.py::test_read_dialog_timeout_ec2_stack -vvvv }}