Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Adding ec2 service stack test #9991

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

niyazRedhat
Copy link
Contributor

@niyazRedhat niyazRedhat commented Mar 16, 2020

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_provision_stack.py::test_read_dialog_timeout_ec2_stack -vvvv }}

testSteps:
1. create an aws template with an optional value "timeout"
2. create a dialog that will offer an option to overwrite "timeout"
with a custom value typed at input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is step 1 and 2 happening ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sshveta from orchestration file we create the template and as per yaml data it gives the dialog input field in order page https://github.com/ManageIQ/integration_tests/tree/master/data/orchestration

@niyazRedhat niyazRedhat changed the title [WIPTEST] Adding ec2 service stack test [RFR] Adding ec2 service stack test Mar 18, 2020
@sshveta sshveta changed the title [RFR] Adding ec2 service stack test [1LP][RFR] Adding ec2 service stack test Mar 18, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR single comment

3.
4. the value input should be passed
"""
msg = "<AEMethod groupsequencecheck> dialog_stack_timeout: 20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niyazRedhat I think better to use regular expression for such match. I'm suspect about whitespace.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its okay here without it because there is no backslash, but for future use @niyazRedhat, its good to use the syntax for the string that includes an 'r' r"<some-regex-string>".

This is a stringprefix in python, part of the string literal definition. It stands for raw string (not regex string) and will treat the backslashes regularly used in regex as literal.

https://docs.python.org/3.7/reference/lexical_analysis.html#grammar-token-stringprefix

@digitronik digitronik self-assigned this Mar 24, 2020
@digitronik digitronik added the test-automation To be applied on PR's which are automating existing manual cases label Mar 24, 2020
@dajoRH dajoRH changed the title [1LP][RFR] Adding ec2 service stack test [1LP][WIP] Adding ec2 service stack test Mar 25, 2020
@niyazRedhat niyazRedhat changed the title [1LP][WIP] Adding ec2 service stack test [1LP][WIPTEST] Adding ec2 service stack test Mar 25, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Mar 25, 2020
@niyazRedhat niyazRedhat changed the title [1LP][WIPTEST] Adding ec2 service stack test [1LP][RFR] Adding ec2 service stack test Mar 25, 2020
@mshriver mshriver self-assigned this Mar 26, 2020
@mshriver mshriver merged commit a0821b6 into ManageIQ:master Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants