Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Transfer tests to jhenner. #9984

Merged
merged 4 commits into from
Mar 23, 2020
Merged

[1LP][RFR] Transfer tests to jhenner. #9984

merged 4 commits into from
Mar 23, 2020

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Mar 13, 2020

There is naming clash of centralized control (at the moment also
often called Replication) with HA tests, marked as Replication as well.
I belive these are very different features. So I've:

  • Created new polarion marker for the Ha proxy tests.
  • Set polarion markers have been set on the tests.
  • Set the casecomponent to HAProxy on HA proxy related tests.

@jarovo jarovo changed the title Transfer HA tests from sbulage to jhenner. [RFR] Transfer HA tests from sbulage to jhenner. Mar 13, 2020
@dajoRH dajoRH added the lint-ok label Mar 13, 2020
Comment on lines 192 to 218
ha_proxy = pytest.mark.requirement(
"Database HA proxy",
description='Databse HA proxy and replication',
assignee_id='jhenner',
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaryN Should we also remove the replication test requirement? Or are there still tests using the replication requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests that are left with replication marker should be mdnadeems. I am sending him a request for renaming/updating the description to say these are centralized-admin tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaryN Replication FA is owned by Devidas Gaikwad

@dgaikwad , Could you please have a look into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaryN Databse HA proxy and replication are two different focus area. I think you can remove replication string from ha_proxy description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaryN Databse HA proxy and replication are two different focus area. I think you can remove replication string from ha_proxy description.

@dgaikwad For HA you need to have data replicated (https://access.redhat.com/documentation/en-us/red_hat_cloudforms/5.0/html-single/high_availability_guide/index#configuring_primary_db). But by my understanding it is quite different kind of replication than that is done in your focus area which I believe should be named Centralized administration (https://access.redhat.com/documentation/en-us/red_hat_cloudforms/4.7/html-single/deployment_planning_guide/index#central-administration)

Some replication is done in both focus areas.

@john-dupuy john-dupuy changed the title [RFR] Transfer HA tests from sbulage to jhenner. [1LP][RFR] Transfer HA tests from sbulage to jhenner. Mar 13, 2020
@mshriver mshriver changed the title [1LP][RFR] Transfer HA tests from sbulage to jhenner. [1LP][WIPTEST] Transfer HA tests from sbulage to jhenner. Mar 13, 2020
@@ -189,6 +189,12 @@ def test_quota_alert():
assignee_id='pvala',
)

ha_proxy = pytest.mark.requirement(
"Database HA proxy",
description='Databse HA proxy and replication',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, missing an a in Databse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -131,6 +131,7 @@ docstrings:
- Provisioning
- Quota
- Replication
- HAProxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this casecomponent to Polarion, please don't change this string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jarovo jarovo changed the title [1LP][WIPTEST] Transfer HA tests from sbulage to jhenner. [1LP][WIPTEST] Transfer HA tests to jhenner. Mar 17, 2020
@jarovo jarovo changed the title [1LP][WIPTEST] Transfer HA tests to jhenner. [1LP][WIPTEST] Transfer tests to jhenner. Mar 17, 2020
@dajoRH dajoRH changed the title [1LP][WIPTEST] Transfer tests to jhenner. [1LP][WIP] Transfer tests to jhenner. Mar 19, 2020
Jaroslav Henner added 4 commits March 20, 2020 12:59
There is naming clash of centralized control (at the moment also
often called Replication) with HA tests, marked as Replication as well.
I belive these are very different features. So I've:

 * Created new polarion marker for the Ha proxy tests.
 * Set polarion markers have been set on the tests.
 * Set the casecomponent to HAProxy on HA proxy related tests.
@jarovo jarovo changed the title [1LP][WIP] Transfer tests to jhenner. [1LP][RFR] Transfer tests to jhenner. Mar 23, 2020
@dajoRH dajoRH removed the WIP label Mar 23, 2020
@jawatts jawatts added the manual For things concerning manual test definitions label Mar 23, 2020
@jawatts jawatts merged commit 008820b into ManageIQ:master Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok manual For things concerning manual test definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants