This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Update widgetastic.patternfly to fix FlashMessages exception handling #9970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates widgetastic.patternfly to include the changes in:
Add NoSuchElementException handling back into FlashMessages.
RedHatQE/widgetastic.patternfly#118
This will resolve the test failures caused by NoSuchElementException errors in recent SSUI tests, such as the following:
It appears that although cfme.base.ssui.LoginPage includes a nested FlashMessages view, the corresponding div element does not actually exist when viewing the page in the browser. A future PR should clean up this and other view classes that include FlashMessages but shouldn't.
{{ pytest: cfme/tests/ssui/test_ssui_dashboard.py -v }}