This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fix locator 5.11 #9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dupuy
reviewed
Feb 28, 2020
widgetastic_manageiq/__init__.py
Outdated
| '/span[contains(@class,"dual-pane-mapper-item-container")]' | ||
| ITEMS_LOCATOR = VersionPick( | ||
| { | ||
| "5.11": './div/div/span[contains(@class,"dual-pane-mapper-item-container")]', |
There was a problem hiding this comment.
Are the prepended div's necessary? I.e. could you just do:
.//span[contains(@class,"dual-pane-mapper-item-container")]
john-dupuy
reviewed
Feb 28, 2020
|
@sshveta , thanks for this PR. Could you pls look into the Travis CI build failure and get this PR merged ? Just an FYI, I pulled these changes locally and the test_v2v_infra_map_ui test passed locally. |
john-dupuy
approved these changes
Mar 5, 2020
nachandr
approved these changes
Mar 5, 2020
digitronik
approved these changes
Mar 5, 2020
| SELECTED_ITEMS_LOCATOR = ( | ||
| './div[contains(@class,"selected")]/div/div' | ||
| './/div[contains(@class,"selected")]/..' |
There was a problem hiding this comment.
Optional: I would use parent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ pytest: cfme/tests/v2v/test_v2v_migrations_ui.py --use-template-cache --provider-limit 2 --use-provider osp13-ims --use-provider vsphere65-nested -qsvv -k test_v2v_infra_map_ui}}